Ask Your Question
0

Can XPySort work in LibreOffice?

asked 2019-07-27 07:45:20 +0200

FrogFan gravatar image

updated 2019-07-27 16:16:07 +0200

Hi,

I'm migrating an OO workbook to LO. I make use of the array sort function extension XPySort in OO but, try as I might, I can't make it work in LO. I install it and the installation seems to proceed without error, but when I try to use it, I get VALUE! errors; the same errors I get when I try to invoke the function without installing the extension.

Is there any way to make this function work in LO? Is there a similar array sort function that does?

Thanks for any help.

Edited to add: File uploaded.C:\fakepath\Test sort LibO.ods

edit retag flag offensive close merge delete

Comments

From list of error codes in Calc:
519 #VALUE No result (#VALUE is in the cell rather than Err:519!) - The formula yields a value that does not correspond to the definition; or a cell that is referenced in the formula contains text instead of a number.

Thus I'd suppose the error is not related to the extension, but to the type of data in some cells. But one thing os absolutely weird. How could you call a function from an extension without the extension being installed (according to ...the same errors I get when I try to invoke the function without installing the extension). This normally would result in#NAME? error. Could you upload an anonymized version of your file?

Opaque gravatar imageOpaque ( 2019-07-27 12:04:00 +0200 )edit

Thanks for the quick response. I originally developed this workbook in OO, where the extension was installed. Then I opened the file in LO -- before installing the extension -- and got the VALUE! errors. Those errors prompted me to install the extension. When I did, the VALUE! errors did not go away.

I have a small file that illustrates this. If you open the file in OO Calc with this extension installed, there will be no errors. If you open the same file in LO with the extension installed, you'll get the VALUE! errors.

I'm new here and don't know how to upload a file. If you'll give me a hint, I'll upload the file. Sorry, I figured out how to upload a file to the original question. You should see the file there.

Thanks again very much.

FrogFan gravatar imageFrogFan ( 2019-07-27 16:00:30 +0200 )edit

Hello again,

Before I posted here, I posted this question over on the OpenOffice forums here When I didn't get a response, I thought I'd try here. I didn't not intentionally cross-post.

Villeroy suspects a Python2 vs. Python3 issue but doesn't have time to debug now, and I understand.

I don't know Python at all, so I'm not in a position to debug myself.

I'm in no particular hurry, but any help is really appreciated.

Thanks.

FrogFan gravatar imageFrogFan ( 2019-07-27 21:13:39 +0200 )edit

I think that this part:

the same errors I get when I try to invoke the function without installing the extension

is incorrect (based on false memory): I have tested the attached document (without the "extension" installed), and indeed, it results in #NAME?, as @Opaque reasonably expected.

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-28 06:09:50 +0200 )edit

Sorry for the misdirection. Indeed, I saw a page full of errors and was prompted to install the extension, whereupon I was greeted with another page full of errors. I didn't carefully note the errors the first time, and ended up assuming I had seen the same error the second time.

FrogFan gravatar imageFrogFan ( 2019-07-28 07:02:02 +0200 )edit

Error message:

<class 'NameError'>: name 'unicode' is not defined, traceback follows
  File "[path]\user\uno_packages\cache\uno_packages\lu79842zjpdl.tmp_\XPySort.oxt\PySort.py", line 25, in PySort
    specs = CheckFields(fieldspecs,len(inRange[0]))  #Checks fields for validity
  File "[path]\user\uno_packages\cache\uno_packages\lu79842zjpdl.tmp_\XPySort.oxt\PySort.py", line 254, in CheckFields
    testfields = [tuple([fieldnumbersout[i]] + [getfieldvalue(inArray[i][1],j) if speclen0 > 1 else 0 for j in range(0,4)]) for i in range(speclen)]
  File "[path]\user\uno_packages\cache\uno_packages\lu79842zjpdl.tmp_\XPySort.oxt\PySort.py", line 254, in <listcomp>
    testfields = [tuple([fieldnumbersout[i]] + [getfieldvalue(inArray[i][1],j) if speclen0 > 1 else 0 for j in range(0,4)]) for i in range(speclen)]
Mike Kaganski gravatar imageMike Kaganski ( 2019-07-28 09:56:43 +0200 )edit

... continued

  File "[path]\user\uno_packages\cache\uno_packages\lu79842zjpdl.tmp_\XPySort.oxt\PySort.py", line 254, in <listcomp>
    testfields = [tuple([fieldnumbersout[i]] + [getfieldvalue(inArray[i][1],j) if speclen0 > 1 else 0 for j in range(0,4)]) for i in range(speclen)]
  File "[path]\user\uno_packages\cache\uno_packages\lu79842zjpdl.tmp_\XPySort.oxt\PySort.py", line 272, in getfieldvalue
    if type(s) == unicode:

See https://timothybramlett.com/Strings_B... for some description; it looks like type 'unicode' from Python 2 is 'str' in Python 3.

Just tested: simply replacing unicode with str in the archive's PySort.py and installing that edited version fixes this. No idea how to make it working in both applications (likely need something like top-leven type variable initialized by corresponding type conditionally).

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-28 09:57:24 +0200 )edit

1 Answer

Sort by » oldest newest most voted
1

answered 2019-07-28 11:14:35 +0200

The problem is that the extension's Python code is written for Python 2 (used in OOo and AOO), and uses unicode type when refers to Unicode strings, while Python 3 (used in LibreOffice) uses str for those strings.

The problem is fixed (and the code is compatible with both office suites) by adding this to the PySort.py (and installing the resulting package):

 # SortArray Calc Add-in implementation.
 NUMBER_RE = re.compile(r'[1-9]\d*')

+# unicode from Python 2 is str in Python 3
+try:
+    unicode
+except NameError:
+    unicode = str
+
 class PySortImpl( unohelper.Base, XPySort ):
     def __init__( self, ctx ):
         self.ctx = ctx
edit flag offensive delete link more

Comments

(OT) By the way: Can someone imagine for what reasons neither Calc nor LibreOffice BASIC provide efficient (or any compiled) functions for sorting? Lots of efficient algorithms are available (among them -under some restrictions- linear time-complexity), but implementing them in BASIC is unnecessariy effort - and slows them down by a factor of 100 or higher.

Lupp gravatar imageLupp ( 2019-07-28 11:34:35 +0200 )edit

I don't think that it's possible to come with a generally usable solution to this. The real used algorithm would likely need too many arguments: besides the array, it needs the order of sort columns, and the sort rules for each column. E.g., "natural sort", or lexicographic sort; and language conventions for the text-based sort; sometimes custom sort rules ... While it's possible for a dialog in UI (which could use e.g. locally-defined sort rules), it's hardly possible for a function in Calc, or for Basic where no lambdas or function-as-parameter is possible...

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-28 12:35:30 +0200 )edit

An enhanced SortDescriptor might do. The central task should be the creation of an array-like object capable of calling a Sort method applying the descriptor.
Concerning the language dependent settings a Locale object should do. Beyond that sorting of texts (word lists) is a mess anyway. The lack of lambda and of procedural parameters should not be essential if the algorithms can be addressed via an API element.

Lupp gravatar imageLupp ( 2019-07-28 14:21:36 +0200 )edit

Hi,

@Mike Kaganski, Is there a new version of the .oxt file that incorporates your change for me to download and test in my workbook? I'm not familiar with Python and don't know how to build a package, but I'll learn if that's for me to do.

Thanks for your help.

FrogFan gravatar imageFrogFan ( 2019-07-28 17:42:05 +0200 )edit

@FrogFan: see my postto the original extension topic at https://forum.openoffice.org.

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-29 03:54:26 +0200 )edit

Thank you, Mike Kaganski! I've downloaded it and it is working great. Problem solved.

FrogFan gravatar imageFrogFan ( 2019-07-29 04:17:37 +0200 )edit

A note for myself: to debug this kind of problem, a breakpoint may be put to ScUnoAddInCall::ExecuteCallWithArgs in the catch handlers; and then inspect rWrapped for the useful wrapped exception's message.

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-29 05:44:18 +0200 )edit

(OT cont'd) @Lupp: so you seem to agree that in case of Calc, the imagined spreadsheet function would have overwhelmingly more complicated usage than all the current functions. Let's discuss the API case. You propose to add some API just to allow users to use some (useful) algorithm. But that's not how it's done in LibreOffice (and its predecessors). We don't create APIs for the only purpose of being available to scripts. They are added only for more important goals: to access some functionality available in core; to ensure compatibility (with other suites - see VBA set of APIs); to make use of other APIs possible (some Basic things like ConvertToURL fall into that category). Making some new utility API just because "we can do it" kind of makes LibreOffice pretend to be a "general-purpose library", which it is not.

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-29 07:27:14 +0200 )edit

(again OT as above mentioned)
Of course you are right under relevant aspects, and as a developer you know most issues concerning the context much better than I can. However, I mainly had in mind the sorting algorithm(s) already "available in core". There is no standard function making them available for sorting arrays, and user code trying to make them available has to accept a lot of overhead (temporary helper sheet e.g.) very likely giving away the gained efficiency and more.

Lupp gravatar imageLupp ( 2019-07-29 13:59:06 +0200 )edit

You refer to the Sort tool. But having that implemented only as GUI, and not as API, allows to avoid making the tool "set in stone": any API is a contract both in terms of syntax and behaviour, and any API change is a breaking change. Most times, when we need to change APIs, we have to add new version of them, keeping the legacy ones for compatibility (and so, increasing maintenance cost). So making the sort tool an API would be less than you wrote (it would only be a table-sorting thing, not a general-purpose algorithm - or else we'd need to expand/change its implementation considerably, making this not exposing something already available in core), while at the same time, make it next to impossible to modify and improve it. Even any bug fix in the sorting algorithm would be a breakage of someone's custom macro. Not ...(more)

Mike Kaganski gravatar imageMike Kaganski ( 2019-07-29 23:54:17 +0200 )edit
Login/Signup to Answer

Question Tools

1 follower

Stats

Asked: 2019-07-27 07:45:20 +0200

Seen: 39 times

Last updated: Jul 28