Extension AltSearch - bugs and requests

[mikekaganski]

@KamilLanda it would be good to publish the extension on a resource like github, to allow contributions (PRs) from anyone interested, not only requests like “@KamilLanda do this and that”

[KamilLanda]

@mikekaganski

publish the extension on a resource like github

Really good idea! But the problem is I nearly absolutely don’t know how to work with Github.
@fpy you ran this newAltSearch-adventure, wouldn’t you admin the Github&Extension version? Or somebody else who knows how to work with these systems?

[fpy]

@KamilLanda

wouldn’t you admin

sure.
seems it now needs another channel
→ https://community.documentfoundation.org/t/collaborative-dev-maintenance-on-altsearch/13005
let’s see

[fpy]

@KamilLanda

Github

so, let’s go with GitHub - gitxpy/libreoffice-alt-search

I have initialized it with current 1.4.2 from extensions.libreoffice.org,
then merged the changes from @bantoniof 1.4.3b

To minimize the learning curve, you can get the files with a simple download :

then submit changes by dragging your directory back to Upload files · gitxpy/libreoffice-alt-search · GitHub

Feel free to try and ask assistance if needed

PS.
a bit of background of course wouldn’t hurt; e.g. Hello World - GitHub Docs

[bantoniof]

Some improvements In GIthub

I think all the code of the extension must be in a subdirectory.

So in the root directory you can put some utilities like the Readme.md, the update information, the compiled extension and a batch to compress the extension.

(Look at my extension on github) GitHub - Bantoniof/LibreOffice-SanityCheck: Extensión para LibreOffice Writer

[KamilLanda]

@fpy marvellous work, thanks for manual with printscreens! But you are too much fast for me in these days . I will try it probably next week, I really want to finish the translation of comments. Module AltSearch is translated that is about 30%.

[fpy]

@KamilLanda

next week

sure, no hurry.

you’ve noticed @bantoniof did already a few translations : 1.4.3b from @bantoniof by gitxpy · Pull Request #4 · gitxpy/libreoffice-alt-search · GitHub

@bantoniof

put some

fair.
hope some unit tests at some point;
also, do you know if there’s a batch upload to extensions.libreoffice.org ?

anyhow, let’s first have @KamilLanda up to speed colfortably, then try to move forward.

[bantoniof]

@fpy

you’ve noticed @bantoniof did already a few translations

• The translations I’ve made was for the localization in Spanis that wasn’t update to v1.4.2
• I think that @KamilLanda want to translate the code comments to English, so the code can be more comprensible.

@fpy

do you know if there’s a batch upload to extensions.libreoffice.org ?

I Don’t know, I suspect not it is possible because you must log in the extensions page to publish the extension. (But you can do the extension updatable from Github)

[KamilLanda]

I already added Spanish translations from @bantoniof to version I make

[bantoniof]

@KamilLanda

And author agreed to change the licence to CC0

Yes, Now I found where is my confussion.

• The previous license was LGPL
• We changed the license to CCO
• When publissing in Github, GIthub added an Apache v2 license file with name LICENSE (can see in branchs) And in the organization I put this file in the “registration” subdir.

---

So…

• In the help the link to the license must be to CCO
• The file /registration/license.txt must contain the real CCO license.

[KamilLanda]

Here is new version
altsearch_150beta1.oxt.RENAMED.ODT (762.8 kB)
The description is in module changes

@fpy or @bantoniof I haven’t own internet so I must periodically “travel” to my neighbourgh’s wifi and do the operations only with touchpad, that really isn’t comfortable for more Drag&Drop operations. So please could you also take from @htietze the administration of Libre Extension site? Thanks.

[bantoniof]

Hellow @KamilLanda, Thanks a lot for your translation work

Testing the 150beta I found a bug:

Searching for char Style “Destacado” in Spanish localized version ( Realname = Emphasis)
I get the incorrect property value error in line 2842 (Function getRealStyleName)

(The 143beta version was ok )

Windows 10, L.O. 25.2.3.2

[KamilLanda]

Ok fixed, 150beta1 up

[bantoniof]

I have replaced the function getRealStyleName with the old function (143b) and the search is ok.

But now, the Replace with another Char Style causes the not established object variable error
(in the same line)

• May be different forms of call to function in search / replace?

[KamilLanda]

In 143 the function getRealStyleName(…) had 1st parameter the object but in 150 is 1st parameter string!
It was easier to change the parameter to string than create new variable with next object in other calling that was with \A in Replace and not only \C.
But I forgot to change it in all occurences of getRealStyleName in 150.


But the uploaded 150beta1 is functional for me:

[bantoniof]

I had not realized that you had edited the message and uploaded the new version. (beta1).

• Tested and is Ok .

• Thank you very much You are very efficient and fast

[fpy]

@KamilLanda

Drag&Drop

ok. so, catching up with commits, the first was HUGE !!
150beta1 is more reasonable / readable

→ Commits · gitxpy/libreoffice-alt-search · GitHub

[KamilLanda]

@fpy you can do really small fix now, there stayed cs comment in Common.xba

:

[KamilLanda]

@fpy please will you also take over the administration of Extension site AltSearch » Libreoffice Extensions ?

[fpy]

@KamilLanda

really

done.

can’t wait you directly join the github vibe

@KamilLanda

administration

the beta is available from latest git main :